Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-1234: Test #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ARROW-1234: Test #10

wants to merge 1 commit into from

Conversation

kou
Copy link
Owner

@kou kou commented Jan 7, 2021

No description provided.

Repository owner deleted a comment from codecov-io Jan 7, 2021
@kou kou changed the title Test Test x Jan 7, 2021
@kou kou changed the title Test x Test Jan 7, 2021
@kou kou changed the title Test Test x Jan 7, 2021
@kou kou changed the title Test x Test Jan 7, 2021
@kou kou changed the title Test Testx Jan 7, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@kou kou changed the title Testx Test x Jan 7, 2021
@kou kou changed the title Test x ARROW-1234: Test Jan 7, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

@kou kou force-pushed the pull-request-title-check-test branch from 43eb24a to 043bd97 Compare January 7, 2021 03:44
Repository owner deleted a comment from codecov-io Jan 7, 2021
kou pushed a commit that referenced this pull request Apr 9, 2021
From a deadlocked run...

```
#0  0x00007f8a5d48dccd in __lll_lock_wait () from /lib64/libpthread.so.0
#1  0x00007f8a5d486f05 in pthread_mutex_lock () from /lib64/libpthread.so.0
#2  0x00007f8a566e7e89 in arrow::internal::FnOnce<void ()>::FnImpl<arrow::Future<Aws::Utils::Outcome<Aws::S3::Model::ListObjectsV2Result, Aws::S3::S3Error> >::Callback<arrow::fs::(anonymous namespace)::TreeWalker::ListObjectsV2Handler> >::invoke() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#3  0x00007f8a5650efa0 in arrow::FutureImpl::AddCallback(arrow::internal::FnOnce<void ()>) () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#4  0x00007f8a566e67a9 in arrow::fs::(anonymous namespace)::TreeWalker::ListObjectsV2Handler::SpawnListObjectsV2() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#5  0x00007f8a566e723f in arrow::fs::(anonymous namespace)::TreeWalker::WalkChild(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int) () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#6  0x00007f8a566e827d in arrow::internal::FnOnce<void ()>::FnImpl<arrow::Future<Aws::Utils::Outcome<Aws::S3::Model::ListObjectsV2Result, Aws::S3::S3Error> >::Callback<arrow::fs::(anonymous namespace)::TreeWalker::ListObjectsV2Handler> >::invoke() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#7  0x00007f8a5650efa0 in arrow::FutureImpl::AddCallback(arrow::internal::FnOnce<void ()>) () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#8  0x00007f8a566e67a9 in arrow::fs::(anonymous namespace)::TreeWalker::ListObjectsV2Handler::SpawnListObjectsV2() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#9  0x00007f8a566e723f in arrow::fs::(anonymous namespace)::TreeWalker::WalkChild(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int) () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#10 0x00007f8a566e74b1 in arrow::fs::(anonymous namespace)::TreeWalker::DoWalk() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
```

The callback `ListObjectsV2Handler` is being called recursively and the mutex is non-reentrant thus deadlock.

To fix it I got rid of the mutex on `TreeWalker` by using `arrow::util::internal::TaskGroup` instead of manually tracking the #/status of in-flight requests.

Closes apache#9842 from westonpace/bugfix/arrow-12040

Lead-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@kou
Copy link
Owner Author

kou commented Sep 9, 2021

@github-actions autotune everything

1 similar comment
@kou
Copy link
Owner Author

kou commented Sep 9, 2021

@github-actions autotune everything

@kou kou force-pushed the pull-request-title-check-test branch from 043bd97 to 6065eb7 Compare September 9, 2021 00:22
@kou
Copy link
Owner Author

kou commented Sep 9, 2021

@github-actions autotune everything

Repository owner deleted a comment from codecov-commenter Sep 9, 2021
kou pushed a commit that referenced this pull request Jul 14, 2022
…ation (apache#13579)

When locally building the `conda-cpp-valgrind` docker image I've realised we are prompting for confirmation:

```
#10 12.35 Confirm changes: [Y/n] 
#10 88.01  
```
We should use the -y flag when using mamba install:
```
  -y, --yes             Do not ask for confirmation.
```
With this change we are no longer seeing the `Confirm changes` message from mamba.

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant